Module:Hatnote - Revision history

Vincent: 46 revisions imported

2019-09-10T01:33:39Z

46 revisions imported

en>JJMC89: Add navigation-not-searchable class per request (also see T164781)

2017-05-09T05:20:32Z

Add navigation-not-searchable class per request (also see T164781)

en>Nihiltres: Non-breaking space after "§" in _formatLink() to match Module:Section link; might not be a bad idea to require() that module but this is a good start

2016-06-23T14:47:33Z

Non-breaking space after "§" in _formatLink() to match Module:Section link; might not be a bad idea to require() that module but this is a good start

en>Nihiltres: Updated from sandbox: tweaked _formatLink() to overwrite, rather than stack, manual piping with "display"-based piping

2016-05-12T15:30:44Z

Updated from sandbox: tweaked _formatLink() to overwrite, rather than stack, manual piping with "display"-based piping

en>Nihiltres: Added a simple p.disambiguate(page [, disambiguator]) helper function

2016-05-05T17:11:59Z

Added a simple p.disambiguate(page [, disambiguator]) helper function

en>Mr. Stradivarius: add role="note" for screen readers per protected edit request by User:Matt Fitzpatrick

2016-02-12T01:36:19Z

add role="note" for screen readers per protected edit request by User:Matt Fitzpatrick

en>Mr. Stradivarius: fix a mistake in the module comments; allow overriding the title in makeWikitextError; allow people to call _hatnote without an options table; and remove a comment about usage, as it is now covered in the test cases

2016-01-29T05:40:14Z

fix a mistake in the module comments; allow overriding the title in makeWikitextError; allow people to call _hatnote without an options table; and remove a comment about usage, as it is now covered in the test cases

en>Mr. Stradivarius: sorry about that; we need to keep findNamespaceId around for other modules

2016-01-28T23:35:36Z

sorry about that; we need to keep findNamespaceId around for other modules

en>Qed237: Reverted 1 edit by Mr. Stradivarius (talk): Error in module:main while using module:sports table. (TW)

2016-01-28T23:31:35Z

Reverted 1 edit by Mr. Stradivarius (talk): Error in module:main while using module:sports table. (TW)

en>Mr. Stradivarius: tidy up the code now that we are adding colons to all the links

2016-01-28T23:27:19Z

tidy up the code now that we are adding colons to all the links

@@ Line 204: / Line 204: @@
 	checkType('_hatnote', 2, options, 'table', true)
 	options = options or {}
-	local classes = {'hatnote'}
+	local classes = {'hatnote', 'navigation-not-searchable'}
 	local extraclasses = options.extraclasses
 	local selfref = options.selfref

@@ Line 162: / Line 162: @@
 		local page, section = link:match('^(.-)#(.*)$')
 		if page then
-			display = page .. ' § ' .. section
+			display = page .. ' §&nbsp;' .. section
 		end
 	end

@@ Line 168: / Line 168: @@
 	-- Assemble the link.
 	if display then
-		return string.format('[[:%s|%s]]', link, display)
+		return string.format(
 	else
 		return string.format('[[:%s]]', link)

@@ Line 109: / Line 109: @@
 		category
+	)
 end

@@ Line 201: / Line 201: @@
 	end
 	return string.format(
-		'<div class="%s">%s</div>',
+		'<div role="note" class="%s">%s</div>',
 		table.concat(classes, ' '),
+		s

← Older revision	Revision as of 01:33, 10 September 2019
(No difference)

@@ Line 34: / Line 34: @@
 	-- function will not work if the link is enclosed in double brackets. Colons
 	-- are trimmed from the start of the link by default. To skip colon
-	-- trimming, set the removeColon parameter to true.
+	-- trimming, set the removeColon parameter to false.
 	checkType('findNamespaceId', 1, link, 'string')
 	checkType('findNamespaceId', 2, removeColon, 'boolean', true)
@@ Line 77: / Line 75: @@
 end
-function p.makeWikitextError(msg, helpLink, addTrackingCategory)
+function p.makeWikitextError(msg, helpLink, addTrackingCategory, title)
 	-- Formats an error message to be returned to wikitext. If
 	-- addTrackingCategory is not false after being returned from
@@ Line 85: / Line 83: @@
 	checkType('makeWikitextError', 2, helpLink, 'string', true)
 	yesno = require('Module:Yesno')
-	local title = mw.title.getCurrentTitle()
+	title = title or mw.title.getCurrentTitle()
 	-- Make the help link text.
 	local helpText
@@ Line 192: / Line 190: @@
 	checkType('_hatnote', 1, s, 'string')
 	checkType('_hatnote', 2, options, 'table', true)
 	local classes = {'hatnote'}
 	local extraclasses = options.extraclasses

@@ Line 35: / Line 35: @@
 	-- are trimmed from the start of the link by default. To skip colon
 	-- trimming, set the removeColon parameter to true.
 	checkType('findNamespaceId', 1, link, 'string')
 	checkType('findNamespaceId', 2, removeColon, 'boolean', true)
@@ Line 135: / Line 137: @@
 function p._formatLink(link, display)
 	checkType('_formatLink', 1, link, 'string')
 	checkType('_formatLink', 2, display, 'string', true)
 	link = removeInitialColon(link)
 	-- Find whether a faux display value has been added with the {{!}} magic
@@ Line 169: / Line 161: @@
 	-- Assemble the link.
 	if display then
-		return string.format('[[%s%s|%s]]', colon, link, display)
+		return string.format('[[:%s|%s]]', link, display)
 	else
-		return string.format('[[%s%s]]', colon, link)
+		return string.format('[[:%s]]', link)
 	end
 end